search

raku-community-modules / URI

Raku realization of URI — Uniform Resource Identifiers handler
Artistic License 2.0
3 stars 14 forks source link

META6.json URI version "v0.1.4" instead of "0.1.4"? #40

Closed CurtTilmes closed 5 years ago

CurtTilmes commented 5 years ago

Why does META6.json have version with a 'v' prefix? Everything I read in docs (docs, Design, S11 seems to recommend it as numbers without the 'v' prefix.

If I run zef info URI, it reports:

- Info for: URI
- Identity: URI:ver<.0.1.4>
...

but when I try to install it with that identity, it fails:

zef install --force "URI:ver<.0.1.4>"
===> Searching for: URI:ver<.0.1.4>
No candidates found matching identity: URI:ver<.0.1.4>
Altai-man commented 5 years ago

I have rights to update the current version with e.g. 0.1.5, will it be enough? Just on github though, not possible e.g. CPAN release.

CurtTilmes commented 5 years ago

zef says URI is hosted on github, so I think if you re-released it with a proper version 0.1.5 everything would work, even without a CPAN release. (Greatly appreciated since it is breaking my integration checks..) I filed a zef issue to see if that could be patched to prevent issues like this in the future.

jonathanstowe commented 5 years ago

Test::META actually tests for this very thing.

CurtTilmes commented 5 years ago

Would be cool if every module used Test::META on their own metadata. Could (should?) zef check META6.json with Test::META and fail the install if the metadata is bad? (unless --force'd to install)

Altai-man commented 5 years ago

I have bumped the version with https://github.com/perl6-community-modules/uri/commit/b645ffdcf02ee685d2c438673b8c9c37a4375d9c And made a release - https://github.com/perl6-community-modules/uri/releases/tag/0.1.5 Please, close the issue if this helps, or suggest what else can be done to improve the situation. :)

Altai-man commented 5 years ago

Also, it is probably just me, but I wonder if 0.1.5 is too shy. I mean, 0.1 is not really a big version for something that is apparently used in the ecosystem relatively often. Didn't review the library though.

CurtTilmes commented 5 years ago

That fixed my problem -- it picked up 0.1.5.

Thanks!