search

rakudo-p5 / v5

v5.pm for rakudo
24 stars 8 forks source link

Rename src/ dir to lib/ #16

Closed paultcochrane closed 7 years ago

paultcochrane commented 7 years ago

Using the name lib/ for where the library files are kept is the Perl standard location. This ensures that standard invocations using prove or PERL6LIB follow the same pattern everywhere. The Build.pm was also updated to account for the change in directory structure.

I'm not 100% sure if that change is truly wanted, however it caused me to stumble while trying out the test suite and I thought it'd cause otjhers headaches as well. Also, if one uses lib for library files then the Travis scripts will work out of the box rather than one having to define a special script section to handle the change in library path location. If this change isn't wanted, then I'm fully ok with it being closed unmerged :-)

paultcochrane commented 7 years ago

Hrm, have just dug further into the test failures I was seeing. Using an alternative name for the library files was intentional, right? So that one can load perl5 libraries which are then located under a lib directory?

FROGGS commented 7 years ago

IIRC the problem was that panda would try to build all modules from lib/, and I prevented it from doing it by moving the stuff to src/.

paultcochrane commented 7 years ago

In which case the patch is basically unnecessary. Sorry for the noise!