rakudo / rakudo.org

Code for rakudo.org website
https://rakudo.org/
Artistic License 2.0
8 stars 18 forks source link

rakudo.org website install from source instruction broken #91

Open librasteve opened 2 years ago

librasteve commented 2 years ago

This page:

https://rakudo.org/star/source

States:

echo "export PATH=$(pwd)/bin/:$(pwd)/share/perl6/site/bin:$(pwd)/share/perl6/vendor/bin:$(pwd)/share/perl6/core/bin:\$PATH" >> ~/.bashrc

But: $(pwd)/bin/: <= this has a TRAILING SLASH That gives this: which raku => /root/rakudo/bin//raku <= this has TWO SLASHES

May trip up unsuspecting users...

On a related note, when using Dockerfile one is in /bin/sh and this seems to choke on mkdir ~/rakudo && cd $_ so perhaps mkdir ~/rakudo && cd ~/rakudo would be more helpful

2colours commented 1 year ago

The trailing slash has been removed here: https://github.com/rakudo/rakudo.org/commit/f9edbb8c97786937c80d2fa2c9440031a95ea8ac

cd $_ should be removed here: https://github.com/rakudo/rakudo.org/pull/90

Is there anything else? :)