rakudo / star

Rakudo Star (Raku distribution)
https://rakudo.org/
Artistic License 2.0
265 stars 41 forks source link

"make modules-test" failure on oo-monitors #113

Closed ronaldxs closed 6 years ago

ronaldxs commented 6 years ago

"make modules-test" succeeds as a whole likely because of #21, but I noticed the oo-monitors test output flash by in red and captured it in a file:

Testing modules/oo-monitors with /home/ron/perl6/rakudo-star-2018.04/install/bin/perl6-m...
t/BUILD.t ...... t/BUILD.t ...... 1/1                       ^Mt/BUILD.t ...... ok
t/basic.t ...... t/basic.t ...... 1/4                       ^Mt/basic.t ...... ok
t/condition.t .. t/condition.t .. 1/6 t/condition.t .. 2/6                       t/condition.t .. ok
t/new.t ........ t/new.t ........ 1/1                       t/new.t ........ ok
t/precomp.t .... ===SORRY!===^M
Could not find Test::Counter at line 2 in:
...

t/precomp.t is failing because of a module called Test::Counter that is only used for testing. modules-test.pl seems to want to run the tests against installed/pre-compiled libraries and since Test::Counter wasn't installed it appears missing. Perhaps lib\Test\Counter.pm could be moved to something like libt\Test\Counter.pm6 and modules-test.pl could be tweaked to include libt\ with -I or PERL6LIB.

Attempting to install: rakudo-star-2018.04 on Ubuntu 14.04.5 LTS.

stmuk commented 6 years ago

It installed without failures for me. I suspect the test fails when run for a second time (?) Maybe open this issue against the oo-monitors repo itself.

ronaldxs commented 6 years ago

My issue was not any difficulty installing oo-monitors. What I described were test failures during make modules-test which would probably happen after the module is installed.

stmuk commented 6 years ago

@ronaldxs That's what I meant.

ronaldxs commented 6 years ago

Should be fixed by jnthn/oo-monitors#13.

stmuk commented 6 years ago

Thanks! I will bump the version in the forthcoming 2018.06 release (due by Monday night European time).