rakudo / star

Rakudo Star (Raku distribution)
https://rakudo.org/
Artistic License 2.0
266 stars 41 forks source link

WSL target modules-install-m failed for "make install" and "make modules-test" #114

Closed ronaldxs closed 6 years ago

ronaldxs commented 6 years ago

Rakudo Star 2018-04 on Windows Subsystem for Linux (WSL) Ubuntu 16.04.4

make install or make modules-test :

sh: 1: Syntax error: "(" unexpected
Makefile:65: recipe for target 'modules-install-m' failed
make: *** [modules-install-m] Error 2

I think this fails on any system with a space in $PATH. On windows paths can be expected to have directories with spaces and parens like "/mnt/c/Program Files (x86)". The modules-install-m target is trying to set the path before getting zef to install itself and it looks like the double quote for sh -c " ... " is expanding too early. I am guessing the cmd /c " ... " will be OK but on *NIX we need something like sh -c 'PATH="$PATH: ... " ... '. I have not tested modules-install-j yet but would expect the problem to effect that target too.

stmuk commented 6 years ago

Reopening to remind me to test this with the release of Star 2018.07.