search

rakudo / star

Rakudo Star (Raku distribution)
https://rakudo.org/
Artistic License 2.0
266 stars 41 forks source link

Get Rakudo Star working for 2019.07.1 #144

Closed Tyil closed 4 years ago

Tyil commented 5 years ago

As announced in #143, here is my PR with a number of fixes to get the process working for 2019.07.1.

This includes a little rewriting to be clearer and cleaner. All the work is now done in the aptly named work directory. If you need to be sure to have a clean build, just rm -fr work. Additionally, there's a clean target for the Makefile which will do the same.

# make -f tools/star/Makefile clean
rm -fr work

A number of scripts have been made available in bin, which should make it even easier for people to build the Rakudo Star distribution tarball, and to make it release-ready.

Due to my testing with GitLab, there's a .gitlab-ci.yml being introduced, which will trigger GitLab CI to build and test the release tarball. A Dockerfile has also been added, which allows GitLab CI to automatically build and push new Docker images of Rakudo Star on each commit. (This is set to be changed to only trigger on tags.)

All modules have been updated, and their directory names have been changed to be a single standard. This allows for easier and more accurate maintenance. I have also incorporated @JJ's #138.

The patch target of the Makefile is currently not used, as it failed to apply and it seemed to be rather harmless to forget about it, for now. We can reintroduce it at a later point once we have verified that the release process itself is now correct.

The tarball I've created with the current setup can be found at https://dist.tyil.nl/raku/rakudo-star. If anyone feels like testing to confirm it works on more machines than just mine, please feel free to do so and report any issues.

Fixes #143 Fixes #138

stmuk commented 5 years ago

Using the release tarball (on macOS 10.15.1)

==> Installing: Shell::Command
===> Installing: LibraryMake:ver<1.0.0>:auth<github:retupmoca>
===> Building: Linenoise:ver<0.1.1>:auth<Rob Hoelz>
[Linenoise] ===SORRY!===
[Linenoise] Failed to open file /Users/steve/temp/rakudo-star-2019.07.1/modules/Linenoise/lib/Linenoise.pm6: No such file or directory
===> Building [FAIL]: Linenoise:ver<0.1.1>:auth<Rob Hoelz>
[Linenoise] Failed to build, but continuing with --force-build
===> Installing: Linenoise:ver<0.1.1>:auth<Rob Hoelz>
===> Install [FAIL] for Linenoise:ver<0.1.1>:auth<Rob Hoelz>: Failed to open file /Users/steve/temp/rakudo-star-2019.07.1/modules/Linenoise/lib/Linenoise.pm6: No such file or directory
Failed to open file /Users/steve/temp/rakudo-star-2019.07.1/modules/Linenoise/lib/Linenoise.pm6: No such file or directory

Rakudo Star has been built and installed successfully.
Please make sure that the following directories are in PATH:
  /Users/steve/rakudo/bin
  /Users/steve/rakudo/share/perl6/site/bin
Tyil commented 4 years ago

Thanks for the test, @stmuk! I've gotten reports about Linenoise issues on the perl6-users mailing list too, so I will spend some time to see if I can get this issue resolved.

stmuk commented 4 years ago

@Tyil my guess is the change in zef flags (which were supplied originally by @ugexe I think)

michael-776 commented 4 years ago

Worked for me, thanks :)

--edit: I spoke too soon: make modules-test gives the same "[Linenoise] Failed to open file..." error.

cat /etc/debian_version 10.1

wget 'https://dist.tyil.nl/raku/rakudo-star/rakudo-star-2019.07.1.tar.gz'

perl Configure.pl --gen-moar --gen-nqp --backends=moar

make rakudo-test

All tests successful.

Test Summary Report

t/09-moar/Line_Break__LineBreak.t (Wstat: 0 Tests: 2 Failed: 0) TODO passed: 1 t/09-moar/General_Category__extracted-DerivedGeneralCategory.t (Wstat: 0 Tests: 1 Failed: 0) TODO passed: 1 Files=98, Tests=1760, 63 wallclock secs ( 0.82 usr 0.19 sys + 373.64 cusr 26.00 csys = 400.65 CPU) Result: PASS

Tyil commented 4 years ago

@stmuk I've reverted the changes in module-install.pl, only to find that now zef wasn't installing anything anymore. Upon inspection, it seems that the flags to disable remote sources are causing it to fail completely (--/p6c, --/metacpan, --/cpan). I've disabled just those three for now. I've not made a new release yet, but those tracking master on the GitLab repository can test it out.

UPDATE: Seems like that does not change the outcome of the test: https://gitlab.com/tyil/rakudo-star/-/jobs/347060779.

/builds/tyil/rakudo-star/work/install/bin/perl6-m /builds/tyil/rakudo-star/work/install/share/perl6/site/bin/zef-m --/build-depends --/test-depends --/depends --force install ./modules/Linenoise
===> Building: Linenoise:ver<0.1.1>:auth<Rob Hoelz>
Failed to open file /builds/tyil/rakudo-star/work/build/rakudo-star-master/modules/Linenoise/lib/Linenoise.pm6: No such file or directory
[Linenoise] ===SORRY!===
[Linenoise] Failed to open file /builds/tyil/rakudo-star/work/build/rakudo-star-master/modules/Linenoise/lib/Linenoise.pm6: No such file or directory
===> Building [FAIL]: Linenoise:ver<0.1.1>:auth<Rob Hoelz>
[Linenoise] Failed to build, but continuing with --force-build
===> Testing: Linenoise:ver<0.1.1>:auth<Rob Hoelz>
===> Testing [OK] for Linenoise:ver<0.1.1>:auth<Rob Hoelz>
===> Installing: Linenoise:ver<0.1.1>:auth<Rob Hoelz>
===> Install [FAIL] for Linenoise:ver<0.1.1>:auth<Rob Hoelz>: Failed to open file /builds/tyil/rakudo-star/work/build/rakudo-star-master/modules/Linenoise/lib/Linenoise.pm6: No such file or directory
Tyil commented 4 years ago

I've still found no way to fix Linenoise, but I can get Readline working, so that's what I'm going for now unless someone with more knowledge on Linenoise can come around and help me fix that.

I've discovered another issue, though. HTTP::UserAgent depends on Encode, and Encode fails it's testing phase. Due to --force it is still installed, but if possible I'd like to solve the issue. It seems it can't find itself during testing.

===> Testing: Encode:ver<0.0.2>:auth<github:sergot>
[Encode] ===SORRY!===
[Encode] Could not find Encode at line 2 in:
[Encode]     file#/tmp/rakudo-star/rakudo-star-2019.07-rc3/modules/Encode
[Encode]     inst#/root/.perl6
[Encode]     inst#/usr/local/share/perl6/site
[Encode]     inst#/usr/local/share/perl6/vendor
[Encode]     inst#/usr/local/share/perl6/core
[Encode]     ap#
[Encode]     nqp#
[Encode]     perl5#
ugexe commented 4 years ago

You need to delete ~/.zef — Encode uses the deprecated (and now no longer supported) META.info. zef creates a META6.json at extraction time, but if it’s already cached then extraction time won’t get the chance to fix it.

JJ commented 4 years ago

We could also patch that...

ugexe commented 4 years ago

Yes, that is the obvious answer and naturally people already tried to solve it that way 2 years ago when the PR was sent.

JJ commented 4 years ago

Sorry, I don't get whether you're being ironic or not. I guess you mean this PR https://github.com/sergot/perl6-encode/pull/11 which was not merged, and I gues that's not going to happen. I guess another option is to adopt that module into the perl6-community-modules namespace?

JJ commented 4 years ago

Linenoise seems to be abandoned https://github.com/hoelzro/p6-linenoise/issues/29#issuecomment-554646409

Tyil commented 4 years ago

@ugexe Alright, thanks for the information! I would personally prefer fixing the module, but I'm unsure if pulling it into the community repository is the best way to go about it. Should we open a different discussion issue about this somewhere?

@JJ Ah, that's quite a fresh comment. If it's abandoned, I feel more comfortable to drop it for Readline for now.

JJ commented 4 years ago

I have now write privs into Linenoise. Maybe we can try and fix it?

Tyil commented 4 years ago

It would be neat if we can fix it, but I'd have no clue where to start.

JJ commented 4 years ago

I can't do this momentarily, so if you're in a hurry to release Rakudo Star let's skip it for now, and get it ready for next release.

Tyil commented 4 years ago

On Tue, 19 Nov 2019 00:12:09 -0800 Juan Julián Merelo Guervós notifications@github.com wrote:

I can't do this momentarily, so if you're in a hurry to release Rakudo Star let's skip it for now, and get it ready for next release.

I'm not in a particular hurry, but I would like to have a working release before Christmas, to end the year with a new Rakudo Star for the community.

I can fork the Encode module and apply the fix ugexe recommended, and use that version instead for now, if that fixes the Encode issue. That coupled with the use of Readline instead of Linenoise should produce a Rakudo Star that has no module issues.

-- With kind regards,

Patrick Spek

www: https://www.tyil.nl/ mail: p.spek@tyil.nl pgp: 1660 F6A2 DFA7 5347 322A 4DC0 7A6A C285 E2D9 8827

social: https://soc.fglt.nl/tyil git: https://gitlab.com/tyil/

JJ commented 4 years ago

I can probably make that one...

El mar., 19 nov. 2019 a las 9:14, Patrick Spek (notifications@github.com) escribió:

On Tue, 19 Nov 2019 00:12:09 -0800 Juan Julián Merelo Guervós notifications@github.com wrote:

I can't do this momentarily, so if you're in a hurry to release Rakudo Star let's skip it for now, and get it ready for next release.

I'm not in a particular hurry, but I would like to have a working release before Christmas, to end the year with a new Rakudo Star for the community.

I can fork the Encode module and apply the fix ugexe recommended, and use that version instead for now, if that fixes the Encode issue. That coupled with the use of Readline instead of Linenoise should produce a Rakudo Star that has no module issues.

-- With kind regards,

Patrick Spek

www: https://www.tyil.nl/ mail: p.spek@tyil.nl pgp: 1660 F6A2 DFA7 5347 322A 4DC0 7A6A C285 E2D9 8827

social: https://soc.fglt.nl/tyil git: https://gitlab.com/tyil/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rakudo/star/pull/144?email_source=notifications&email_token=AAAAD5BTXP5RRD3UEORKK3DQUON7FA5CNFSM4JI75KY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEENIFDQ#issuecomment-555385486, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAD5HSKIFQELUIO56YJULQUON7FANCNFSM4JI75KYQ .

-- JJ

JJ commented 4 years ago

The patch for Encode has been merged ;-). Thanks @sergot

Tyil commented 4 years ago

Thanks JJ, I'll update it soon-ish and make a new build!

On Thu, 21 Nov 2019 08:23:47 -0800 Juan Julián Merelo Guervós notifications@github.com wrote:

The patch for Encode has been merged ;-). Thanks @sergot

-- With kind regards,

Patrick Spek

www: https://www.tyil.nl/ mail: p.spek@tyil.nl pgp: 1660 F6A2 DFA7 5347 322A 4DC0 7A6A C285 E2D9 8827

social: https://soc.fglt.nl/tyil git: https://gitlab.com/tyil/

JJ commented 4 years ago

I just merged a PR into linenoise, which fixes Windows. Check it out.

El vie., 22 nov. 2019 a las 9:25, Patrick Spek (notifications@github.com) escribió:

Thanks JJ, I'll update it soon-ish and make a new build!

On Thu, 21 Nov 2019 08:23:47 -0800 Juan Julián Merelo Guervós notifications@github.com wrote:

The patch for Encode has been merged ;-). Thanks @sergot

-- With kind regards,

Patrick Spek

www: https://www.tyil.nl/ mail: p.spek@tyil.nl pgp: 1660 F6A2 DFA7 5347 322A 4DC0 7A6A C285 E2D9 8827

social: https://soc.fglt.nl/tyil git: https://gitlab.com/tyil/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rakudo/star/pull/144?email_source=notifications&email_token=AAAAD5AM7LJOMPHLQH55FKLQU6JRPA5CNFSM4JI75KY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE45QWQ#issuecomment-557439066, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAD5ACXJ4TY6BXIN6EQG3QU6JRPANCNFSM4JI75KYQ .

-- JJ

ugexe commented 4 years ago

That PR should NOT have been merged, and I’ll be vocal to others not to use that anymore. That “windows fix” is broken on multiple levels despite I laid out the lesser of all evils fix elsewhere (I.e. copy OpenSSL)

ugexe commented 4 years ago

I’m fact after looking at it for 30 seconds I’m pretty sure it “doesn’t even work” unless you literally install it. That’s broken — modules should work without being installed.

JJ commented 4 years ago

Does that apply to the Linux version too?

Prince213 commented 4 years ago

No, Linux is not affected.

Tyil commented 4 years ago

The updates pushed just now are those that produced my Rakudo Star 2019.11-rc1. I've received numerous words of it working for people, but none of it not working (apart from one, which turned out to be a forgotten step on the user's part).

Tyil commented 4 years ago

I updated the PR with all commits used up to and included in the release of 2020.01

hankache commented 4 years ago

@Tyil ++