search

rakuri255 / UltraSinger

AI based tool to convert vocals lyrics and pitch from music to autogenerate Ultrastar Deluxe, Midi and notes. It automatic tapping, adding text, pitch vocals and creates karaoke files.
MIT License
265 stars 24 forks source link

Method to download PyHyphen Libraries #102

Open taynaron opened 10 months ago

taynaron commented 10 months ago

Currently, language_check only checks for existing installed hyphenation libraries without providing any method for downloading them. Users only receive an error that something went wrong with hyphenation. Provide some method, automatic or manual, for downloading the needed hyphenation libraries.

rakuri255 commented 10 months ago

Yes, I agree that it reads strangely. But PyHyphen does download the languages itself if the correct langKey is given.

taynaron commented 10 months ago

hm, that doesn't seem to be happening for me. I can look more into why.

taynaron commented 10 months ago

What language do you primarily test with? What I see is that in hyphenate_each_word we detect 'en' and pass that into 'language_check'. This returns 'en' not 'en_US', so when we get to 'create_hyphenator' it doesn't know what to do with 'en' and returns None.

rakuri255 commented 10 months ago

i using en and de