rakuri255 / UltraSinger

AI based tool to convert vocals lyrics and pitch from music to autogenerate Ultrastar Deluxe, Midi and notes. It automatic tapping, adding text, pitch vocals and creates karaoke files.
MIT License
287 stars 26 forks source link

Yarg midi support #152

Open binarygeek119 opened 5 months ago

binarygeek119 commented 5 months ago

Would it be possible to add yarg midi support. Right now the midi output doesn't work with yarg.

Yarg is a new rock band clone that has mic support.

There's two things I like to have.

  1. New song outputs to a yarg midi file.
  2. Update a midi to have lyrics. Like a guitar hero 1-3 song it would keep the notes for the song but add lyrics and pitch to the file. Ideally it would need to support more then one off file or support just lyric parts. As the song rips have the parts broke out in to there own file. Guitar has just the guitar and vocals have singing drums have drums.

Singer txt files do work out of the box with yarg with a little work.

I needed to load the txt file into editor on fire a rock band chart editor then save it. And it works with out doing anything. I do do a bit of clean up, but improving ultrasinger will fix that. It has nothing to do with the convert into a yarg midi.

rakuri255 commented 5 months ago

Sure we can create a file with lyric+pitch. But other instruments could be difficult. With demucs we can separate guitar, drums and maybe also bass and than pitch that. But creating a "good" midi of this could be difficult.

I didnt finde a documentation on "How to create own yarg files". Can you post a link?

binarygeek119 commented 5 months ago

all i was wanting is just lyric+pitch. the other band part would be a manual. with a new file it would just have lyric+pitch which in yarg is vocals. with a existing file it would just add the missing lyric+pitch to the midi but leave the other parts alone. with guitar hero 1-3 that would be guitar and bass and sometime rhythm guitar. https://github.com/YARC-Official/YARG

heres info for the file https://github.com/TheNathannator/GuitarGame_ChartFormats also here is eof (editor on fire) https://ignition4.customsforge.com/eof

rakuri255 commented 5 months ago

eof is intresting. It says it fits also to rocksmith 👨‍🎤 🎸

LanceAkaLance commented 4 months ago

There is a commandline tool for conversion of vocal charts (that is also embedded in eof). Here is the FOF Thread

According to the author the code should be compilable for Linux