rakuri255 / UltraSinger

AI based tool to convert vocals lyrics and pitch from music to autogenerate Ultrastar Deluxe, Midi and notes. It automatic tapping, adding text, pitch vocals and creates karaoke files.
MIT License
238 stars 19 forks source link

Pitcher with gpu support #40

Closed rakuri255 closed 10 months ago

stripu commented 1 year ago

Would integrating a pytorch version of crepe be better for gpu support? Ex, here: https://github.com/maxrmorrison/torchcrepe

rakuri255 commented 1 year ago

Yes, i tested it, but had some integration problems. https://github.com/maxrmorrison/torchcrepe/issues/26

stripu commented 1 year ago

Ahh, I see, it outputs different data compared to original crepe.. Is there anything we could do to get better results with the normal crepe? Right now, pitching seems to be mostly one octave/half octave higher or lower compared to original song pitch

rakuri255 commented 1 year ago

I'm already on the lookout there too. What we need in any case is a short test file where the notes are very clear.

Then the whole chain has to be checked, because every editing step could change the sound.

Also activate --plot True, this makes it easier to analyse

rakuri255 commented 10 months ago

Thanks to @BWagener for adding GPU Support with #89