rakuri255 / UltraSinger

AI based tool to convert vocals lyrics and pitch from music to autogenerate Ultrastar Deluxe, Midi and notes. It automatic tapping, adding text, pitch vocals and creates karaoke files.
MIT License
287 stars 26 forks source link

Crepe with windows GPU support #89

Closed BWagener closed 1 year ago

BWagener commented 1 year ago

This PR is an alternative solution to #87.

The motivation for both was to facilitate GPU usage for crepe. The problem with the original crepe implementation for Python turned out to be a limitation of TensorFlow. For versions after 2.10 GPU support for windows was dropped: https://www.tensorflow.org/install/pip#windows-native (see the red infobox).

This PR downgrades the TensorFlow dependency to the latest available version that still has GPU support.

Another solution would be to leave it as it is and suggest every windows user to install WSL2 and follow the WSL2 specific installation instructions here. For now I really don't like the idea of putting such a barrier of entry to using the program.

Ideally we can find out why torchcrepe is not performing as desired but until then this is a less invasive solution to achieve the goal of facilitating GPU usage for crepe.

If you don't like the other changes in this PR let me know I can split it up.

Other changes introduced in this PR: