search

rakutentech / android-buildconfig

Shared (gradle) build configurations for Android and Java libraries
MIT License
21 stars 26 forks source link

Upgrade agp #56

Closed paulwang007 closed 5 years ago

paulwang007 commented 5 years ago

2 more points:

  • [x] you have a lot of commits, some are unnecessary like the merge commits (just rebase) and one has a slightly incorrect commit message (7fc7136 -> "Upgrade gradlew to 5.2.1"). can you either cherry pick the actual changes onto current master (i.e. no merge commits) or just squash it all into 1 commit (because that would still be a self contained commit imo)
  • [x] DO NOT CLOSE THIS PR AND THEN OPEN ANOTHER ONE! Please just push (with --force if necessary) to your fork's branch and this pull request will be updated. By closing this PR and opening a new one all the previous conversation is lost, that's kinda using the tool to our disadvantage.

^ Resolved

paulwang007 commented 5 years ago

All comments are addressed.

NemoOudeis commented 5 years ago

you can just check the box 😉

paulwang007 commented 5 years ago

you can just check the box 😉

I don't know how to click it, it doesn't seem to let me do it. Even reply to this message can't be done for some reason.

screen shot 2019-03-01 at 09 25 35