Added config to Docpub - Githubissues

rakutentech / docpub

DocPub is a command line utility for converting a folder structure of markdown files to HTML and uploading the result to Zendesk.

MIT License

12 stars 16 forks source link

Added config to Docpub #30

Closed SwinX closed 7 years ago

SwinX commented 7 years ago

Integrated config to uploaders. Also slight uploaders tests refactoring. Resolves #6

SwinX commented 7 years ago

This PR completely covers our initial requirements for config:

Minimum options
Possibility to override options via CLI args or ENV variables

The only thing is that in module I'm using for config and CLI\ENV parsing ENV variables override config if they set. I guess this can be accepted if correctly covered in doc.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 98.849% when pulling 01e84cfda8848e184d577808becc8b1b85d89d1f on feature/config into c933ff47ce5bd72a8f8e37cd2954f79f1d1b57e1 on master.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 98.849% when pulling d451c8e5338e5e8f10c2b671e33133bc3fe7181f on feature/config into dc07ee27c08e2f5e9d5c7b17013b88af08054e49 on master.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 98.849% when pulling d2d3bfacfe6f1a81665eaa462d06ae6f093030f3 on feature/config into dc07ee27c08e2f5e9d5c7b17013b88af08054e49 on master.

corycaywood commented 7 years ago

Also need to update the README with info on the config file and updated environment variable names. (CLI documentation can probably be handled in #22).

coveralls commented 7 years ago

Coverage increased (+0.05%) to 98.855% when pulling 0d508633f3f71813015399da4d047a3c23e17a40 on feature/config into 092bb6ea7c7e555a8ee4cd21b086fd5a2138e40f on master.

SwinX commented 7 years ago

Also need to update the README with info on the config file and updated environment variable names. (CLI documentation can probably be handled in #22).

Yes, true. Created #31 for this.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 98.86% when pulling bd6a8e2d1b9e2ab5732a698139f0077203507926 on feature/config into 092bb6ea7c7e555a8ee4cd21b086fd5a2138e40f on master.