search

rakutentech / shibuya

Apache License 2.0
23 stars 9 forks source link

Engine auto deletion time goes to negative value #62

Open viggates opened 1 year ago

viggates commented 1 year ago

Engine auto deletion time goes to negative value if a run triggered towards the end of deletion time.

Steps to reproduce

  1. Launch a collection
  2. Click on Details section to know the auto deletion time (15 or 30 minutes)
  3. Wait until 1 minute before deletion time
  4. Trigger the collection
  5. Stop the collection but do not purge
  6. Check on Details section again, value should go to negative value past 0 minutes

Possibilities

It could due to a diff between UI side and the GC kick in interval. Because GC runs every 1 minute or so. So in the UI, if it happens got passed deletion time, it may start to show negative values.

iandyh commented 1 year ago

I think the simplest solution will be disabling negative value at the UI side.