search

rakutentech / shibuya

Apache License 2.0
24 stars 9 forks source link

Distributed mode phase 1 #98

Closed iandyh closed 4 months ago

iandyh commented 11 months ago

This implements the issue described here: https://github.com/rakutentech/shibuya/issues/19

In particular, this PR focuses on two main points mentioned here: https://github.com/rakutentech/shibuya/issues/19#issuecomment-1647884910

We essentially split the monolith into two: api and controller.

  1. Put some isolated background task into a separate process. Please bear in mind that, Shibuya will still support non-distributed mode as in the past.
  2. Due to we will have more than 1 deployment to be managed, we will switch to Helm to manage the manifests. There are also some necessary changes:
    • Dockerfile is updated.
    • We will use GitHub Action to build the image for api and controller. GitHub action will also build the charts and release into GitHub. So later users can helm pull xxx to get the install charts.

The GitHub Action build can be seen here: https://github.com/iandyh/shibuya/actions/runs/7137516355/job/1943762659

rsw-a commented 10 months ago

@iandyh

The GitHub Action build can be seen here: https://github.com/iandyh/shibuya/actions/runs/7137516355/job/1943762659

this returns http status 404 to me.

iandyh commented 10 months ago

@rsw-a hmm, could you check this one? https://github.com/iandyh/shibuya/actions/runs/7137516355/job/19437626599

rsw-a commented 10 months ago

@iandyh

@rsw-a hmm, could you check this one? https://github.com/iandyh/shibuya/actions/runs/7137516355/job/19437626599

yep, it works!

iandyh commented 8 months ago

@rsw-a I've either resolved the comment or replied to your comment. Please check. Thx.

iandyh commented 6 months ago

@rsw-a yes. I think I am a fix in my local branch and I’ll send it out later.