Panic on empty networkInterfaces slice in resource_vsphere_virtual_machine resourceVSphereVirtualMachineRead

BenPhegan commented 8 years ago

Hi,

Was investigating a panic associated with a failed VM instantiation. narrowed down to here: https://github.com/rakutentech/terraform-provider-vsphere/blob/master/vsphere/resource_vsphere_virtual_machine.go#L424

    d.SetConnInfo(map[string]string{
        "type": "ssh",
        "host": networkInterfaces[0]["ip_address"].(string),
    })

If there are no network interfaces found, the index to [0] panics.

Wanted to check before providing a pull request what the intended resolution should be around this? If the expectation is that there should always be at least one network interface, then perhaps a panic is valid (although it might still be worth adding some logging). Otherwise, logging and guard code.

Let me know your thoughts, and I can look at putting up a pull request. Will also be digging into the root cause, as this is only a symptom of an incorrectly created VM (may be my config).

Thanks,

Ben

tkak commented 8 years ago

Basically, I think the panic error does not occur because network interface parameter is required. But logging message and guard code looks good. I welcome your pull request :) Thanks!

BenPhegan commented 8 years ago

Apparently I cannot attach a log, will supply as a comment.

BenPhegan commented 8 years ago

2015/10/09 08:56:20 [INFO] Terraform version: 0.6.3 234f49a2c93fecdecd803d7562e0d394dd12ae42+CHANGES 2015/10/09 08:56:20 Detected home directory from env var: /Users/pheganb 2015/10/09 08:56:20 [DEBUG] Discovered plugin: atlas = /usr/local/bin/terraform-provider-atlas 2015/10/09 08:56:20 [DEBUG] Discovered plugin: aws = /usr/local/bin/terraform-provider-aws 2015/10/09 08:56:20 [DEBUG] Discovered plugin: azure = /usr/local/bin/terraform-provider-azure 2015/10/09 08:56:20 [DEBUG] Discovered plugin: cloudflare = /usr/local/bin/terraform-provider-cloudflare 2015/10/09 08:56:20 [DEBUG] Discovered plugin: cloudstack = /usr/local/bin/terraform-provider-cloudstack 2015/10/09 08:56:20 [DEBUG] Discovered plugin: consul = /usr/local/bin/terraform-provider-consul 2015/10/09 08:56:20 [DEBUG] Discovered plugin: digitalocean = /usr/local/bin/terraform-provider-digitalocean 2015/10/09 08:56:20 [DEBUG] Discovered plugin: dme = /usr/local/bin/terraform-provider-dme 2015/10/09 08:56:20 [DEBUG] Discovered plugin: dnsimple = /usr/local/bin/terraform-provider-dnsimple 2015/10/09 08:56:20 [DEBUG] Discovered plugin: docker = /usr/local/bin/terraform-provider-docker 2015/10/09 08:56:20 [DEBUG] Discovered plugin: google = /usr/local/bin/terraform-provider-google 2015/10/09 08:56:20 [DEBUG] Discovered plugin: heroku = /usr/local/bin/terraform-provider-heroku 2015/10/09 08:56:20 [DEBUG] Discovered plugin: mailgun = /usr/local/bin/terraform-provider-mailgun 2015/10/09 08:56:20 [DEBUG] Discovered plugin: null = /usr/local/bin/terraform-provider-null 2015/10/09 08:56:20 [DEBUG] Discovered plugin: openstack = /usr/local/bin/terraform-provider-openstack 2015/10/09 08:56:20 [DEBUG] Discovered plugin: template = /usr/local/bin/terraform-provider-template 2015/10/09 08:56:20 [DEBUG] Discovered plugin: terraform = /usr/local/bin/terraform-provider-terraform 2015/10/09 08:56:20 [DEBUG] Discovered plugin: vsphere = /usr/local/bin/terraform-provider-vsphere 2015/10/09 08:56:20 [DEBUG] Discovered plugin: chef = /usr/local/bin/terraform-provisioner-chef 2015/10/09 08:56:20 [DEBUG] Discovered plugin: file = /usr/local/bin/terraform-provisioner-file 2015/10/09 08:56:20 [DEBUG] Discovered plugin: local-exec = /usr/local/bin/terraform-provisioner-local-exec 2015/10/09 08:56:20 [DEBUG] Discovered plugin: remote-exec = /usr/local/bin/terraform-provisioner-remote-exec 2015/10/09 08:56:20 Detected home directory from env var: /Users/pheganb 2015/10/09 08:56:20 [DEBUG] Attempting to open CLI config file: /Users/pheganb/.terraformrc 2015/10/09 08:56:20 [DEBUG] File doesn't exist, but doesn't need to. Ignoring. 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.ConfigTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.OrphanTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.AddOutputOrphanTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.MissingProviderTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.ProviderTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.DisableProviderTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.MissingProvisionerTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.ProvisionerTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.VertexTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.FlattenTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.ProxyTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.RootTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec root provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec vsphere_virtual_machine.default var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.TargetsTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec root provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec vsphere_virtual_machine.default var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.PruneProviderTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec root provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec vsphere_virtual_machine.default var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.PruneProvisionerTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec root provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec vsphere_virtual_machine.default var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.DestroyTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec root provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec vsphere_virtual_machine.default var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere vsphere_virtual_machine.default (destroy tainted) vsphere_virtual_machine.default (destroy) vsphere_virtual_machine.default (destroy tainted) provider.vsphere vsphere_virtual_machine.default (destroy) provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.CreateBeforeDestroyTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec root provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec vsphere_virtual_machine.default var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere vsphere_virtual_machine.default (destroy tainted) vsphere_virtual_machine.default (destroy) vsphere_virtual_machine.default (destroy tainted) provider.vsphere vsphere_virtual_machine.default (destroy) provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.PruneDestroyTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec root provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec vsphere_virtual_machine.default var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.PruneNoopTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec root provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec vsphere_virtual_machine.default var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.CloseProviderTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provider.vsphere (close) provider.vsphere vsphere_virtual_machine.default provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec root provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec vsphere_virtual_machine.default var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.CloseProvisionerTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provider.vsphere (close) provider.vsphere vsphere_virtual_machine.default provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec root provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec vsphere_virtual_machine.default var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.RootTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provider.vsphere (close) provider.vsphere vsphere_virtual_machine.default provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec root provider.vsphere (close) provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec vsphere_virtual_machine.default var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.TransitiveReductionTransformer:

provider.vsphere var.vsphere_password var.vsphere_user var.vsphere_vcenter provider.vsphere (close) vsphere_virtual_machine.default provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec root provider.vsphere (close) provisioner.chef provisioner.file provisioner.local-exec provisioner.remote-exec var.vsphere_password var.vsphere_user var.vsphere_vcenter vsphere_virtual_machine.default provider.vsphere 2015/10/09 08:56:20 [INFO] Starting graph walk: walkInput 2015/10/09 08:56:20 Detected home directory from env var: /Users/pheganb 2015/10/09 08:56:20 [DEBUG] vertex root.provisioner.local-exec: walking 2015/10/09 08:56:20 [DEBUG] vertex root.provisioner.local-exec: evaluating 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalInitProvisioner 2015/10/09 08:56:20 [DEBUG] Starting plugin: /usr/local/bin/terraform-provisioner-local-exec []string{"/usr/local/bin/terraform-provisioner-local-exec"} 2015/10/09 08:56:20 [DEBUG] Waiting for RPC address for: /usr/local/bin/terraform-provisioner-local-exec 2015/10/09 08:56:20 terraform-provisioner-local-exec: 2015/10/09 08:56:20 Plugin address: unix /var/folders/46/8qy5pg_15nn_5rwxbjf6bhfm0000gq/T/tf-plugin391781786 2015/10/09 08:56:20 [DEBUG] vertex root.provisioner.remote-exec: walking 2015/10/09 08:56:20 [DEBUG] vertex root.provisioner.remote-exec: evaluating 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalInitProvisioner 2015/10/09 08:56:20 [DEBUG] vertex root.var.vsphere_user: walking 2015/10/09 08:56:20 [DEBUG] vertex root.var.vsphere_user: evaluating 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalNoop 2015/10/09 08:56:20 [DEBUG] vertex root.var.vsphere_password: walking 2015/10/09 08:56:20 [DEBUG] vertex root.var.vsphere_password: evaluating 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalNoop 2015/10/09 08:56:20 [DEBUG] vertex provider.vsphere, got dep: var.vsphere_password 2015/10/09 08:56:20 [DEBUG] vertex root.var.vsphere_vcenter: walking 2015/10/09 08:56:20 [DEBUG] vertex root.var.vsphere_vcenter: evaluating 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalNoop 2015/10/09 08:56:20 [DEBUG] vertex provider.vsphere, got dep: var.vsphere_vcenter 2015/10/09 08:56:20 [DEBUG] vertex provider.vsphere, got dep: var.vsphere_user 2015/10/09 08:56:20 [DEBUG] vertex root.provisioner.chef: walking 2015/10/09 08:56:20 [DEBUG] vertex root.provisioner.chef: evaluating 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalInitProvisioner 2015/10/09 08:56:20 [DEBUG] vertex root.provider.vsphere: walking 2015/10/09 08:56:20 [DEBUG] vertex root.provider.vsphere: evaluating 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalSequence 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalInitProvider 2015/10/09 08:56:20 [DEBUG] Starting plugin: /usr/local/bin/terraform-provider-vsphere []string{"/usr/local/bin/terraform-provider-vsphere"} 2015/10/09 08:56:20 [DEBUG] vertex root.provisioner.file: walking 2015/10/09 08:56:20 [DEBUG] vertex root.provisioner.file: evaluating 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalInitProvisioner 2015/10/09 08:56:20 [DEBUG] Waiting for RPC address for: /usr/local/bin/terraform-provider-vsphere 2015/10/09 08:56:20 [DEBUG] Starting plugin: /usr/local/bin/terraform-provisioner-remote-exec []string{"/usr/local/bin/terraform-provisioner-remote-exec"} 2015/10/09 08:56:20 [DEBUG] Waiting for RPC address for: /usr/local/bin/terraform-provisioner-remote-exec 2015/10/09 08:56:20 terraform-provisioner-remote-exec: 2015/10/09 08:56:20 Plugin address: unix /var/folders/46/8qy5pg_15nn_5rwxbjf6bhfm0000gq/T/tf-plugin636667450 2015/10/09 08:56:20 [DEBUG] Starting plugin: /usr/local/bin/terraform-provisioner-file []string{"/usr/local/bin/terraform-provisioner-file"} 2015/10/09 08:56:20 [DEBUG] vertex root, got dep: provisioner.remote-exec 2015/10/09 08:56:20 [DEBUG] Waiting for RPC address for: /usr/local/bin/terraform-provisioner-file 2015/10/09 08:56:20 terraform-provisioner-file: 2015/10/09 08:56:20 Plugin address: unix /var/folders/46/8qy5pg_15nn_5rwxbjf6bhfm0000gq/T/tf-plugin061893747 2015/10/09 08:56:20 terraform-provider-vsphere: 2015/10/09 08:56:20 Plugin address: unix /var/folders/46/8qy5pg_15nn_5rwxbjf6bhfm0000gq/T/tf-plugin017733791 2015/10/09 08:56:20 [DEBUG] Starting plugin: /usr/local/bin/terraform-provisioner-chef []string{"/usr/local/bin/terraform-provisioner-chef"} 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalOpFilter 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalSequence 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalGetProvider 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalInterpolate 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalBuildProviderConfig 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalInputProvider 2015/10/09 08:56:20 [DEBUG] Waiting for RPC address for: /usr/local/bin/terraform-provisioner-chef 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalNoop 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalNoop 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalNoop 2015/10/09 08:56:20 [DEBUG] vertex vsphere_virtual_machine.default, got dep: provider.vsphere 2015/10/09 08:56:20 [DEBUG] vertex root.vsphere_virtual_machine.default: walking 2015/10/09 08:56:20 [DEBUG] vertex root.vsphere_virtual_machine.default: evaluating 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalSequence 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalInterpolate 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalNoop 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalCountFixZeroOneBoundary 2015/10/09 08:56:20 [DEBUG] vertex root.vsphere_virtual_machine.default: expanding/walking dynamic subgraph 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.ResourceCountTransformer:

vsphere_virtual_machine.default 2015/10/09 08:56:20 [TRACE] Graph after step *terraform.RootTransformer:

vsphere_virtual_machine.default 2015/10/09 08:56:20 [DEBUG] vertex root.vsphere_virtual_machine.default: walking 2015/10/09 08:56:20 [DEBUG] vertex root.vsphere_virtual_machine.default: evaluating 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalSequence 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalNoop 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalInstanceInfo 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalNoop 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalNoop 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalNoop 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalNoop 2015/10/09 08:56:20 [DEBUG] vertex provider.vsphere (close), got dep: vsphere_virtual_machine.default 2015/10/09 08:56:20 [DEBUG] vertex root.provider.vsphere (close): walking 2015/10/09 08:56:20 [DEBUG] vertex root.provider.vsphere (close): evaluating 2015/10/09 08:56:20 [DEBUG] root: eval: terraform.EvalCloseProvider 2015/10/09 08:56:20 [DEBUG] vertex root, got dep: provider.vsphere (close) 2015/10/09 08:56:20 terraform-provisioner-chef: 2015/10/09 08:56:20 Plugin address: unix /var/folders/46/8qy5pg_15nn_5rwxbjf6bhfm0000gq/T/tf-plugin165487224 2015/10/09 08:56:20 [DEBUG] vertex root, got dep: provisioner.chef 2015/10/09 08:56:20 [DEBUG] vertex root, got dep: provisioner.file 2015/10/09 08:56:20 [DEBUG] vertex root, got dep: provisioner.local-exec 2015/10/09 08:56:20 [DEBUG] vertex root.root: walking 2015/10/09 08:56:20 [TRACE] Graph after step terraform.ConfigTransformer: