search

rakyll / hey

HTTP load generator, ApacheBench (ab) replacement
Apache License 2.0
17.69k stars 1.18k forks source link

Rename "DNS-lookup" to "DNS lookup" in the report? #123

Open ngrilly opened 5 years ago

ngrilly commented 5 years ago

I have doubts about the meaning of "DNS+dialup" and "DNS-lookup" in the reports produced by hey:

Details (average, fastest, slowest):
  DNS+dialup:   0.2696 secs, 0.0004 secs, 7.2027 secs
  DNS-lookup:   0.0000 secs, 0.0000 secs, 0.0000 secs
  req write:    0.0001 secs, 0.0000 secs, 0.0113 secs
  resp wait:    0.0004 secs, 0.0001 secs, 0.0078 secs
  resp read:    0.0001 secs, 0.0000 secs, 0.0092 secs

After a quick glance at the code here and here, it looks like "DNS+dialup" is the sum of the DNS lookup duration and the connection dial up duration, and "DNS-lookup" is the DNS lookup duration alone.

The spelling "DNS-lookup" suggests it is the duration of the DNS lookup minus some other "lookup".

Should we rename it to "DNS lookup"?

rakyll commented 5 years ago

Renaming it to "DNS lookup" sounds good.