Add optional TLS session resumption

rakyll / hey

HTTP load generator, ApacheBench (ab) replacement

Apache License 2.0

17.65k stars 1.17k forks source link

Add optional TLS session resumption #199

Open costela opened 4 years ago

costela commented 4 years ago

This small PR fixes #198

The flag name is obviously up for bikeshedding! :wink:

I also took the liberty of adding a very small missing test, which is unrelated to the PR, but was throwing a vet error.

costela commented 4 years ago

Quick unscientific benchmarks with a local noop TLS server:

Without TLS session resumption:

$ hey -c 300 -q 2000 -z 10s -disable-keepalive https://localhost:8443
...
Requests/sec:   1291.3949
...
DNS+dialup: 0.2116 secs, 0.0034 secs, 3.6132 secs
...

With TLS session resupmtion:

$ hey -c 300 -q 2000 -z 10s -disable-keepalive -tls-session-resume https://localhost:8443
...
Requests/sec:   4023.0482
...
DNS+dialup: 0.0595 secs, 0.0009 secs, 3.0997 secs
...

emilras commented 2 years ago

I would love to see this merged in :-)

Any ideas to get thing moving? @costela @moroswitie

costela commented 2 years ago

@emilras unfortunately no :disappointed:

AFAICT @rakyll is the only one who can actually merge stuff and it looks like this project has unfortunately slid a few spots down her priority list (understandably, time being a limited resource :wink:)

emilras commented 2 years ago

@costela Yeah, time is always the issue. Thanks for replying. Let's hope @rakyll one day comes back and do a merge :-)