search

rakyll / hey

HTTP load generator, ApacheBench (ab) replacement
Apache License 2.0
17.99k stars 1.19k forks source link

hey approve prometheus #271

Open zgxme opened 2 years ago

zgxme commented 2 years ago

Hey, I have an idea of making hey realize visualization. And I made it,let hey approve prometheus. Does the community have any plans for this?

this is my final version https://github.com/rickzhen/hey/releases/tag/v0.2.0

FrenchBen commented 2 years ago

I think it would be more useful to have a prometheus output supported, instead of the custom integration that you created. hey already supports an output type of CSV.

-o  Output type. If none provided, a summary is printed.
      "csv" is the only supported alternative. Dumps the response
      metrics in comma-separated values format.

Adding support for something like json, would allow a quick and easy integration via https://github.com/prometheus-community/json_exporter

zgxme commented 2 years ago

@FrenchBen yeah, good idea. I want to support real-time metrics.

FrenchBen commented 2 years ago

You mean for the metrics to show up before the run is actually completed? With hey being a tool that has a start/end, it doesn't seem to align with a real-time metrics idea. I see the above as something useful, where hey could run as a cronjob, and for the results to be collected in Prometheus

zgxme commented 2 years ago

@FrenchBen ok, I got it. 👍