search

ral-facilities / datagateway-api

ICAT API to interface with the DataGateway
Apache License 2.0
5 stars 4 forks source link

Disable search API in docker image #473

Closed ajkyffin closed 7 months ago

ajkyffin commented 7 months ago

Description

Remove the search_api section from config.yaml in the docker image, otherwise it fails to load since there is no search API backend available.

Testing Instructions

Agile Board Tracking

N/A

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a9f336c) 96.66% compared to head (e7d658b) 96.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #473 +/- ## ======================================= Coverage 96.66% 96.66% ======================================= Files 39 39 Lines 3242 3242 Branches 317 317 ======================================= Hits 3134 3134 Misses 80 80 Partials 28 28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

louise-davies commented 7 months ago

Why do we need to disable the search api? We'd need it to deploy in production for ISIS at least, and probably eventually for DLS when they have open data.

EDIT: ah, I suppose the need for the PANOSC scoring API is the problem... We currently run an old version of the API for ISIS which doesn't have the PANOSC scoring API in place

ajkyffin commented 7 months ago

Why do we need to disable the search api?

If there is no search backend available, datagateway-api won't start unless it's disabled.

ajkyffin commented 7 months ago

It seems I've been confused between the search api and the new search functionality being worked on in ICat. When the container was failing to load with errors about the search API, I assumed it was because the new search functionality wasn't present. In fact the problem was I had /icat in the icat_url which isn't needed for python-icat.

Anyway, once it's pointing to an ICat server correctly it starts fine. Whether or not it works without the PANOSC scoring API I don't know.