search

ral-facilities / datagateway

DataGateway is a portal that supports discovery and access large science facilities data. It is developed as a plugin for SciGateway
Apache License 2.0
9 stars 5 forks source link

simpler icat timestamps #1619

Closed kaperoo closed 7 months ago

kaperoo commented 7 months ago

Description

Simplified timestamps to ISO 9075 (without milliseconds and time zones). The createTime, modTime, startDate and endDate dates are formatted in table.component to avoid code repetition. All dates are being converted to UTC time zone.

Testing instructions

Agile board tracking

connect to #1605

codecov[bot] commented 7 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (403e34f) 96.16% compared to head (3bc9a31) 96.14%. Report is 32 commits behind head on develop.

Files Patch % Lines
...datagateway-common/src/card/cardView.component.tsx 80.00% 1 Missing :warning:
...s/datagateway-common/src/table/table.component.tsx 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1619 +/- ## =========================================== - Coverage 96.16% 96.14% -0.03% =========================================== Files 170 170 Lines 7485 7495 +10 Branches 2378 2380 +2 =========================================== + Hits 7198 7206 +8 - Misses 266 268 +2 Partials 21 21 ``` | [Flag](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1619/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | Coverage Δ | | |---|---|---| | [common](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1619/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | `95.55% <80.00%> (-0.06%)` | :arrow_down: | | [dataview](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1619/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | `96.95% <ø> (ø)` | | | [download](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1619/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | `95.83% <ø> (ø)` | | | [search](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1619/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | `96.47% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaperoo commented 7 months ago

Added timestamp formatting to card view.