search

ral-facilities / datagateway

DataGateway is a portal that supports discovery and access large science facilities data. It is developed as a plugin for SciGateway
Apache License 2.0
9 stars 5 forks source link

Release v1.1.3 #1640

Closed louise-davies closed 7 months ago

louise-davies commented 7 months ago

Description

Fix performance issue of querying for investigation id in datafile tables by nstead checking the investigation id in id check functions

This release has already been deployed on DLS preprod and prod and works fine - just need to check that CI is happy

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4f29f5e) 97.52% compared to head (8e1075a) 97.52%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1640 +/- ## ======================================= Coverage 97.52% 97.52% ======================================= Files 134 134 Lines 6901 6905 +4 Branches 2069 2070 +1 ======================================= + Hits 6730 6734 +4 Misses 155 155 Partials 16 16 ``` | [Flag](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1640/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | Coverage Δ | | |---|---|---| | [common](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1640/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | `98.17% <ø> (ø)` | | | [dataview](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1640/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | `98.04% <100.00%> (+<0.01%)` | :arrow_up: | | [download](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1640/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | `94.96% <ø> (ø)` | | | [search](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1640/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | `97.37% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

louise-davies commented 7 months ago

One e2e test is failing, but since it's just checking by desc order on the studies table, and everything else works, it's probably a quirk in the old test data somehow