search

ral-facilities / datagateway

DataGateway is a portal that supports discovery and access large science facilities data. It is developed as a plugin for SciGateway
Apache License 2.0
9 stars 5 forks source link

Fix doi minting code #1646

Closed louise-davies closed 6 months ago

louise-davies commented 6 months ago

Description

ral-facilities/icat-doi-minter-api#62 fixed the problematic metadata, but we were then supplying the wrong metadata to the API. This PR adjusts our code to send the API metadata in the format it's happy with

Testing instructions

Add a set up instructions describing how the reviewer should test the code

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f227864) 96.08% compared to head (a079eab) 96.08%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1646 +/- ## ======================================== Coverage 96.08% 96.08% ======================================== Files 170 170 Lines 7209 7209 Branches 2274 2261 -13 ======================================== Hits 6927 6927 Misses 262 262 Partials 20 20 ``` | [Flag](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1646/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | Coverage Δ | | |---|---|---| | [common](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1646/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | `95.23% <ø> (ø)` | | | [dataview](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1646/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | `96.96% <ø> (ø)` | | | [download](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1646/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | `95.99% <100.00%> (ø)` | | | [search](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1646/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | `96.55% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.