Closed louise-davies closed 6 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
fd5869e
) 96.08% compared to head (9341b7f
) 96.25%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
After we stopped using studies for ISIS, there were still TODOs as ISIS hadn't properly finished migrating over to using data publications fully. This PR addresses that. ISIS has 2 types of data publications, a study datapublication, and an investigation one. Some info is only found on the study DP and vice versa, hence why we have to fetch both sometimes as our includes filters can't handle including the same entity type twice.
Also, did some clever stuff so that dataset/datafile views don't care which hierarchy they're in, we convert from the investigation datapub id to investigation id for them.
Also had to adjust how the breadcrumbs work to accommodate ISIS use case.
This now means we can show landing pages (albiet with less info) for closed investigations - which was a huge blocker for us to provide DOI landing pages at all.
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #1528, Closes #1202