search

ral-facilities / datagateway

DataGateway is a portal that supports discovery and access large science facilities data. It is developed as a plugin for SciGateway
Apache License 2.0
9 stars 5 forks source link

Implement new ISIS data publication hierarchy #1528 #1648

Closed louise-davies closed 6 months ago

louise-davies commented 6 months ago

Description

After we stopped using studies for ISIS, there were still TODOs as ISIS hadn't properly finished migrating over to using data publications fully. This PR addresses that. ISIS has 2 types of data publications, a study datapublication, and an investigation one. Some info is only found on the study DP and vice versa, hence why we have to fetch both sometimes as our includes filters can't handle including the same entity type twice.

Also, did some clever stuff so that dataset/datafile views don't care which hierarchy they're in, we convert from the investigation datapub id to investigation id for them.

Also had to adjust how the breadcrumbs work to accommodate ISIS use case.

This now means we can show landing pages (albiet with less info) for closed investigations - which was a huge blocker for us to provide DOI landing pages at all.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

Agile board tracking

Closes #1528, Closes #1202

codecov[bot] commented 6 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (fd5869e) 96.08% compared to head (9341b7f) 96.25%.

Files Patch % Lines
...views/card/isis/isisDatasetsCardView.component.tsx 75.00% 1 Missing :warning:
...card/isis/isisInvestigationsCardView.component.tsx 83.33% 1 Missing :warning:
...s/table/isis/isisInvestigationsTable.component.tsx 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1648 +/- ## =========================================== + Coverage 96.08% 96.25% +0.17% =========================================== Files 170 170 Lines 7209 7326 +117 Branches 2270 2333 +63 =========================================== + Hits 6927 7052 +125 + Misses 262 254 -8 Partials 20 20 ``` | [Flag](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1648/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | Coverage Δ | | |---|---|---| | [common](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | `95.32% <100.00%> (+0.08%)` | :arrow_up: | | [dataview](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | `97.36% <99.02%> (+0.40%)` | :arrow_up: | | [download](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | `95.99% <ø> (ø)` | | | [search](https://app.codecov.io/gh/ral-facilities/datagateway/pull/1648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities) | `96.55% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ral-facilities#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.