ral-facilities / datagateway

DataGateway is a portal that supports discovery and access large science facilities data. It is developed as a plugin for SciGateway
Apache License 2.0
9 stars 5 forks source link

Accessibility evaluation #738

Open agbeltran opened 3 years ago

agbeltran commented 3 years ago

Description: We want to make sure that the web app is accesible.

Some resources to consider: https://www.gov.uk/government/publications/doing-a-basic-accessibility-check-if-you-cant-do-a-detailed-one

https://www.gov.uk/guidance/make-your-website-or-app-accessible-and-publish-an-accessibility-statement?utm_source=CampaignPage&utm_campaign=access_regs#decide-how-to-check-the-accessibility-problems-on-your-website-or-mobile-app

https://wave.webaim.org/

Acceptance criteria:

agbeltran commented 3 years ago

https://www.w3.org/TR/WCAG21/

louise-davies commented 2 years ago

@MRichards99 this should probably now be handed over to someone else, as you're now busy with datagateway-api issues

MRichards99 commented 2 years ago

@louise-davies who would you like this to be handed over to? I'm happy to write up a few notes and meet with the newly assigned person to go through where I got to and what needs to be done once this is decided.

MRichards99 commented 2 years ago

@louise-davies I have added my handover notes onto the SciGateway wiki, also accessible via the sidebar.

I've also created a spreadsheet containing each of the WCAG success criteria and the current status of the audit (pass, fail, N/A or not checked yet). It's on the TopCAT redevelopment SharePoint site but I've deliberately not added a link to it in the markdown.

When we come back to this work, I'm happy to meet with the new person working on it to go through what I've written and answer any questions.

louise-davies commented 2 years ago

we were just given feedback that the blues & purples we use aren't very visible for a colour blind user in darkmode. We may have to come back to this user for more specific feedback, but we should also be considering this. For now I assume that they'd be fine with using light mode...

joshuadkitenge commented 2 years ago

I have found a tool that can simulate different types of colour blindness, and I'm going to redo my contrast evaluation using that.

joelvdavies commented 2 years ago

@louise-davies Using the tool @joshuadkitenge suggested I can immediately see the buttons may cause a problem image. We could make the buttons lighter, or as Joshua pointed out we could create a high contrast dark mode theme like Github does.

louise-davies commented 2 years ago

@joelvdavies I think making a separate theme would probably be suitable as otherwise we'd be chasing the probably impossible dream of getting one theme looking nice for both colourblind and non-colourblind people (although GitHub's colourblind themes are still in beta so we shouldn't beat ourselves up too much about this)

However, if light mode is sufficient and passes tests for colour blindness then I think making a colourblind accessible dark mode could be a lower priority

louise-davies commented 2 years ago

@joshuadkitenge could you perhaps summarise here what are the outstanding things

joshuadkitenge commented 2 years ago

WCAG 1.3.1 (A): Info and Relationships

WCAG 1.4.10 (AA): Reflow

WCAG 2.1.1 (A): Keyboard , WCAG 2.1.3 (AAA): Keyboard (No Exceptions)

WCAG 3.1.4, 3.1.5, 3.16 (AAA): Abbreviations, Reading Level and Pronunciation

WCAG 3.3.5 (AAA): Help

WCAG 3.3.6 (AAA): Error Prevention (All)

WCAG 4.1.2 (A): Name, Role and Value

WCAG 4.1.3 (A): Status Messages

More information

joshuadkitenge commented 2 years ago