Open agbeltran opened 3 years ago
@MRichards99 this should probably now be handed over to someone else, as you're now busy with datagateway-api issues
@louise-davies who would you like this to be handed over to? I'm happy to write up a few notes and meet with the newly assigned person to go through where I got to and what needs to be done once this is decided.
@louise-davies I have added my handover notes onto the SciGateway wiki, also accessible via the sidebar.
I've also created a spreadsheet containing each of the WCAG success criteria and the current status of the audit (pass, fail, N/A or not checked yet). It's on the TopCAT redevelopment SharePoint site but I've deliberately not added a link to it in the markdown.
When we come back to this work, I'm happy to meet with the new person working on it to go through what I've written and answer any questions.
we were just given feedback that the blues & purples we use aren't very visible for a colour blind user in darkmode. We may have to come back to this user for more specific feedback, but we should also be considering this. For now I assume that they'd be fine with using light mode...
I have found a tool that can simulate different types of colour blindness, and I'm going to redo my contrast evaluation using that.
@louise-davies Using the tool @joshuadkitenge suggested I can immediately see the buttons may cause a problem . We could make the buttons lighter, or as Joshua pointed out we could create a high contrast dark mode theme like Github does.
@joelvdavies I think making a separate theme would probably be suitable as otherwise we'd be chasing the probably impossible dream of getting one theme looking nice for both colourblind and non-colourblind people (although GitHub's colourblind themes are still in beta so we shouldn't beat ourselves up too much about this)
However, if light mode is sufficient and passes tests for colour blindness then I think making a colourblind accessible dark mode could be a lower priority
@joshuadkitenge could you perhaps summarise here what are the outstanding things
"Content can be presented without loss of information or functionality, and without requiring scrolling in two dimensions"
Status: Not fixable
For Web pages that require the user to submit information, at least one of the following is true:
For this to pass, we should add a confirmation on download (when a user inputs email address etc.) although I wonder if this would be annoying for a user
Status: Fixable
Adding a minimum height to table view (everywhere)
https://github.com/ral-facilities/datagateway/pull/1063/files (searchPageContainer , line 154)
This would allow WCAG 2.1 AA Reflow to pass
Description: We want to make sure that the web app is accesible.
Some resources to consider: https://www.gov.uk/government/publications/doing-a-basic-accessibility-check-if-you-cant-do-a-detailed-one
https://www.gov.uk/guidance/make-your-website-or-app-accessible-and-publish-an-accessibility-statement?utm_source=CampaignPage&utm_campaign=access_regs#decide-how-to-check-the-accessibility-problems-on-your-website-or-mobile-app
https://wave.webaim.org/
Acceptance criteria: