Closed joelvdavies closed 3 months ago
Just gone through the comments, and have mentioned where they were already present in https://github.com/ral-facilities/inventory-management-system-api/pull/315, otherwise I fixed them in the latest commit there https://github.com/ral-facilities/inventory-management-system-api/pull/315/commits/9ea1038ca2b9fc403c4e12ad01a1cc2a52a8b80c.
Addressed further unresolved comments on https://github.com/ral-facilities/inventory-management-system-api/pull/315/commits/1a20bbf8d8c2857249145490835f4e43a17b467e.
Description
Refactors catalogue category repo unit tests in same format as in #302 as part of #90. There are also some minor changes to the previous tests refactored in that PR as I noticed a few minor inconsistencies while creating this one.
_has_child_elements
and_is_duplicate
as they are repeated, particularly inside the CatalogueCategory unit tests as there they are used via delete and the specifichas_child_elements
tests.System
tosystem
in all comments and error messages (unless its the first word) for consistency.self.test_helpers.
withRepositoryTestHelpers.
for SystemsRepo and CatalogueCategoryRepo unit tests.Testing instructions
Agile board tracking
Closes #305