Closed joelvdavies closed 3 months ago
Could you please also run the black formatter as it has some things to reformat? Thanks
Could you please also run the black formatter as it has some things to reformat? Thanks
I thought I did on the latest force push?
Could you please also run the black formatter as it has some things to reformat? Thanks
I thought I did on the latest force push?
Oh sorry, your last commit did not appear for me when I posted this.
@VKTB Thanks for being thorough and spotting these, I wouldn't have myself.
Description
Refactors catalogue category e2e tests. Also applies changes to all refactored tests so far to match the style of #31.
Notes
Removed tests:
test_create_catalogue_category_with_properties_with_allowed_values
- Tested by the newtest_create_leaf_with_properties
test_partial_update_catalogue_category_change_from_leaf_to_non_leaf
- With the way it is currently writtentest_partial_update_is_leaf_no_children
should be enough for leaf -> non leaf or non-leaf -> leaf as it doesn't care about the value change itself, just whether it is allowed to modify ittest_partial_update_catalogue_category_add_property
,test_partial_update_catalogue_category_remove_property
andtest_partial_update_catalogue_category_modify_property
replaced with one test updating properties (add and removal is irrelevant here)Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #314