Refactor CatalogueCategoryPropertyService unit tests #376

ral-facilities / inventory-management-system-api

Apache License 2.0

1 stars 0 forks source link

Refactor CatalogueCategoryPropertyService unit tests #376 #379

Closed joelvdavies closed 2 months ago

joelvdavies commented 2 months ago

Description

See #376.

Notes

Noticed Catalogue item has NonLeafCatalogueCategoryError for test_create_with_non_leaf_catalogue_category whereas the properties service is currently using InvalidActionError, should these be unified?

Testing instructions

Add a set up instructions describing how the reviewer should test the code

[ ] Review code
[ ] Check Actions build
[ ] Review changes to test coverage

Agile board tracking

Closes #376

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.86%. Comparing base (efed0c5) to head (2f35aa9). Report is 8 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #379 +/- ## ======================================== Coverage 97.86% 97.86% ======================================== Files 41 41 Lines 1502 1502 ======================================== Hits 1470 1470 Misses 32 32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

VKTB commented 2 months ago

Noticed Catalogue item has NonLeafCatalogueCategoryError for test_create_with_non_leaf_catalogue_category whereas the properties service is currently using InvalidActionError, should these be unified?

Yes, they should be.

joelvdavies commented 2 months ago

Yes, they should be.

Created an issue https://github.com/ral-facilities/inventory-management-system-api/issues/381.