Closed asuresh-code closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.16%. Comparing base (
acd243e
) to head (1c95660
). Report is 22 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
- Filter mode: [Fuzzy, Contains, Starts With, Ends With, Not Equals, Between Inclusive] The first 4 are the most useful filter functions for filtering string data. Not equals could be a useful filter for filtering out a value. Between inclusive offers all of the functionality of between,<=,>=, etc, which could be useful to get ranges of text. Every other filter could either be recreated from the chosen 6, or is superfluous.
Code LGTM, just one query on the chosen filter functions. I am not sure what between inclusive means for a text field here? Is it doing a comparison based on the ASCII codes?
- Filter mode: [Fuzzy, Contains, Starts With, Ends With, Not Equals, Between Inclusive] The first 4 are the most useful filter functions for filtering string data. Not equals could be a useful filter for filtering out a value. Between inclusive offers all of the functionality of between,<=,>=, etc, which could be useful to get ranges of text. Every other filter could either be recreated from the chosen 6, or is superfluous.
Code LGTM, just one query on the chosen filter functions. I am not sure what between inclusive means for a text field here? Is it doing a comparison based on the ASCII codes?
It was not clear to me from looking at the implementation of it found here, whether it does it based on ASCII codes. However, that does seem to be the case after I spent some time testing the filter.
It is not case-sensitive, so a lower bound of Z (90) would still exclude lowercase letters like p (112). In the implementation they do convert all string to lowercase before comparison. However, the rest of the characters behave as expected, so numbers (47-58) would include all letters as a lower bound, but exclude all as an upper bound.
Description
Value:
Last Modified/Created:
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
connect to #979