search

ral-facilities / scigateway

SciGateway is the parent application for several plugins providing access to data and compute tools for large Science Facilities
Apache License 2.0
6 stars 4 forks source link

Increase toast functionailty #355 #1376

Closed joshuadkitenge closed 6 months ago

joshuadkitenge commented 6 months ago

Description

Allowed the toast to be shown if the show variable in the payload is "true". Allowed all the toasts to be remove using esc

Testing instructions

Add a set up instructions describing how the reviewer should test the code

Agile board tracking

closes /ral-facilities/inventory-management-system/issues/355

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.76%. Comparing base (4df6e62) to head (e663688).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## react-18-#1205 #1376 +/- ## ================================================== + Coverage 96.75% 96.76% +0.01% ================================================== Files 48 48 Lines 1754 1763 +9 Branches 495 496 +1 ================================================== + Hits 1697 1706 +9 Misses 53 53 Partials 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joshuadkitenge commented 6 months ago

I couldn't get the dispatchEvent working on cypress so I trigger a plugin error and clear that with escape for the e2e test. @louise-davies