ral-facilities / scigateway

SciGateway is the parent application for several plugins providing access to data and compute tools for large Science Facilities
Apache License 2.0
6 stars 4 forks source link

Migrate from CRA to Vite #1379 #1380

Open joelvdavies opened 5 months ago

joelvdavies commented 5 months ago

Description

Replaces CRA with Vite. Used the default settings that create-vite would have generated in the tsconfig. The only real change caused by that is a requirement of underscores on some unused variable & I removed the props on the footer as they weren't either (noUnusedParameters).

Draft as should not be merged until #1275 is.

Notes

[!WARNING]
The index.html has moved out of the public folder into the root, so docker-ims needs to be updated on gitlab as the title can no longer be replaced as it used to be, and instead will be in /dist after being built. Likely also effects any ansible config.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

Agile board tracking

Closes #1379

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 94.82759% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 86.42%. Comparing base (b51eecf) to head (bf9dce6).

Files Patch % Lines
src/i18n.ts 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## react-18-#1205 #1380 +/- ## =================================================== - Coverage 96.76% 86.42% -10.35% =================================================== Files 48 56 +8 Lines 1763 8561 +6798 Branches 497 893 +396 =================================================== + Hits 1706 7399 +5693 - Misses 53 1155 +1102 - Partials 4 7 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 94.54545% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.62%. Comparing base (f0c6d18) to head (384f97b).

Files Patch % Lines
src/i18n.ts 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## react-18-#1205 #1380 +/- ## ================================================== + Coverage 96.95% 97.62% +0.66% ================================================== Files 49 54 +5 Lines 1775 5775 +4000 Branches 491 897 +406 ================================================== + Hits 1721 5638 +3917 - Misses 50 134 +84 + Partials 4 3 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.