Open joelvdavies opened 5 months ago
Attention: Patch coverage is 94.82759%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 86.42%. Comparing base (
b51eecf
) to head (bf9dce6
).
Files | Patch % | Lines |
---|---|---|
src/i18n.ts | 0.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Attention: Patch coverage is 94.54545%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 97.62%. Comparing base (
f0c6d18
) to head (384f97b
).
Files | Patch % | Lines |
---|---|---|
src/i18n.ts | 0.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Replaces CRA with Vite. Used the default settings that create-vite would have generated in the tsconfig. The only real change caused by that is a requirement of underscores on some unused variable & I removed the props on the footer as they weren't either (
noUnusedParameters
).Draft as should not be merged until #1275 is.
Notes
react-redux-toastr
was incompatible (it used jsx in .js file) using old version, so upgraded v7.6.2 -> v7.6.13 which fixedclearInterval
inrouting.component.test.tsx
not being defined which was fixed by https://github.com/testing-library/react-testing-library/issues/1198{ shouldAdvanceTime: true }
in someuseFakeTimers
__mock__
not havingexpect.getState()
assigned as expected - fixed by mocking inside the test file itself (the token storage mock also needed to be hoisted to run correctly as it needed to be done before imports - see description here https://vitest.dev/api/vi#vi-hoisted)eslint-config-react-app
witheslint-plugin-react
,eslint-plugin-testing-library
andeslint-plugin-react-hooks
like https://github.com/ral-facilities/inventory-management-system/pull/372react-app-polyfill
andcustom-event-polyfill
(IE is no longer supported anyway, also see https://vitejs.dev/guide/build#browser-compatibility, we could use @vitejs/plugin-legacy if required)browserslist-to-esbuild
to add support for browserslist (View the currently targeted builds usingnpx browserslist-to-esbuild
)Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #1379