Pin docker base images to SHA

ral-facilities / scigateway

SciGateway is the parent application for several plugins providing access to data and compute tools for large Science Facilities

Apache License 2.0

6 stars 4 forks source link

Pin docker base images to SHA #1382

Closed VKTB closed 5 months ago

VKTB commented 5 months ago

Description

This PR pins the base docker images in the Dockerfiles to commit SHAs so that Renovate (or Dependabot if Renovate doesn't work) can create PRs each time there is a change in the upstream base images that the base images are set to use as new SHAs are generated on every upstream change. Not sure if Renovate will also update the OS versions but if it doesn't then we will have to do the Alpine version updates manually for now.

Please note that I have pinned it to an older SHA to verify that Renovate (or Dependabot if Renovate doesn't work) will create a PR.

Testing instructions

[ ] Review code
[ ] Check Actions build
[ ] Review changes to test coverage

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.78%. Comparing base (d618873) to head (d91774c).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #1382 +/- ## ======================================== Coverage 96.78% 96.78% ======================================== Files 48 48 Lines 1740 1740 Branches 485 491 +6 ======================================== Hits 1684 1684 Misses 52 52 Partials 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

VKTB commented 5 months ago

Renovate did create a PR to update the SHA but it did not bump the OS version so we will have to do this manually https://github.com/ral-facilities/scigateway/pull/1384