ral-facilities / scigateway

SciGateway is the parent application for several plugins providing access to data and compute tools for large Science Facilities
Apache License 2.0
6 stars 4 forks source link

Fix error colour inconsistency for IMS #1393

Closed joelvdavies closed 3 months ago

joelvdavies commented 3 months ago

Description

Resolves issue here: https://github.com/ral-facilities/inventory-management-system/issues/465.

This was caused because we override the error colours for various components but not generally when using the error colour directly. This adds in the override so they are all consistent. This could potentially have an undesired effect on datagateway if using color="error", but I don't think it is being used anywhere I could find, and will only be going in the react-18 branch for the time being anyway,

Testing instructions

Add a set up instructions describing how the reviewer should test the code

Agile board tracking

Closes ral-facilities/inventory-management-system#465

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.93%. Comparing base (bb8375e) to head (f5e88b4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## react-18-#1205 #1393 +/- ## =============================================== Coverage 96.93% 96.93% =============================================== Files 48 48 Lines 1760 1760 Branches 490 490 =============================================== Hits 1706 1706 Misses 50 50 Partials 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.