ralberth / MMM-MysqlQuery

MagicMirror plug-in module that displays a table of MySQL SELECT results
MIT License
8 stars 3 forks source link

mysql.close() not called on connections #2

Closed ralberth closed 5 years ago

ralberth commented 5 years ago

A user is seeing database connection errors:

2018-10-24T11:37:17.264019Z 195 [Note] Aborted connection 195 to db: 'misfit' user: 'beavertrapper07' host: '208-107-85--dynamic.midco.net' (Got timeout reading communication packets)`

This is due to node_helper.js not closing database connections. They're all left dangling without corresponding destroy() calls.

I can't figure out how to make this work right now, so carrying this here as a reminder.

ralberth commented 5 years ago

Quick update, this is still on the list to be done, just having trouble finding time to devote to overhauling this appropriately.

ralberth commented 5 years ago

Just committed what should do the trick here! Please "git pull" from the modules/MMM-MysqlQuery folder and start up everything fresh. Let me know if you're still seeing this problem.