search

ralexstokes / ethereum-consensus

Apache License 2.0
138 stars 55 forks source link

add "no-default-features" build to CI to ensure things work w/o default feature set #283

Open ralexstokes opened 1 year ago

ralexstokes commented 1 year ago

we should have a build step like this in the CI to ensure that things also build w/o default features

https://github.com/ralexstokes/ssz-rs/blob/main/.github/workflows/ci.yml#L37

and it looks like beacon-api-client currently does not succeed!

yash-atreya commented 1 year ago

I can take this

distributedstatemachine commented 12 months ago

@yash-atreya are you still working on this ? happy to take it over the line

yash-atreya commented 12 months ago

@yash-atreya are you still working on this ? happy to take it over the line

Please go ahead.

ralexstokes commented 11 months ago

I think we just need to do this: https://github.com/ralexstokes/ethereum-consensus/pull/284/files#r1355734863

to get that PR ready to merge -- @samtvlabs if you want to make a pass at it, feel free, otherwise I can just do in the next few days

distributedstatemachine commented 9 months ago

Apologies dropped this ball on this will get this over the line this weekend