ralexstokes / mev-rs

a gateway to a network of block builders
Other
420 stars 77 forks source link

support eth transfer to proposers with code #251

Closed rodrigoherrerai closed 6 months ago

rodrigoherrerai commented 6 months ago

implements 248

For the near future would it be better to go with option 3? (simulate the call and based on that use the appropriate gas)

ralexstokes commented 6 months ago

For the near future would it be better to go with option 3? (simulate the call and based on that use the appropriate gas)

possibly, up to some gas limit, as otherwise a proposer could try to grief this builder implementation

and if we do have some fixed gas limit, it starts to look suspiciously like option 2, so not sure the extra complexity is worth it

ralexstokes commented 6 months ago

here's a lido payment: https://etherscan.io/tx/0x252940cec2d0f1d0340a5438f7abcf77f926c26931e5a53e03c10ca3aecd7981

only 22,111 gas

stakefish: https://etherscan.io/tx/0xc9b86901e3155d36f14430779799380e4d43dd4ab50eb9d2ab388ecd9ca2e3a1 21,033 gas

rocket pool smoothing pool: https://etherscan.io/tx/0x153a76aaefeaf09ccaf3b67f3523c5d475c9775bc1fed405247726b4fb7f2031 21,055 gas

so maybe 250k is much too high.... perhaps we just go with 100k for now