search

ralexstokes / ssz-rs

Implementation of ethereum's `ssz`
Apache License 2.0
102 stars 40 forks source link

Remove methods that reimplement underlying functionality of `List` and `Vector` #148

Closed ralexstokes closed 5 months ago

ralexstokes commented 5 months ago

Originally, the mutable APIs into the underlying type that List and Vector wrap were specialized to the local wrapping types so that mutations could be tracked along the way to support caching a la #17.

I'd like to release a v1 of this library and won't have caching support so go ahead and drop the specialized implementations here, in lieu of just exposing the full functionality of the wrapped types.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 64.02%. Comparing base (fddda62) to head (364270b).

Files Patch % Lines
ssz-rs/src/list.rs 50.00% 1 Missing :warning:
ssz-rs/src/vector.rs 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #148 +/- ## ========================================== - Coverage 64.32% 64.02% -0.31% ========================================== Files 20 20 Lines 1183 1173 -10 ========================================== - Hits 761 751 -10 Misses 422 422 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.