ralexstokes / ssz-rs

Implementation of ethereum's `ssz`
Apache License 2.0
103 stars 41 forks source link

`sha2-asm` feature #158

Closed mempirate closed 2 months ago

mempirate commented 2 months ago

Context

This PR implements a feature for enabling the asm feature on the sha2 crate. When testing against a real world payload (generate a proof of transaction inclusion against the transactions root), these are the numbers:

Conclusion

With sha2-asm enabled, proof generation becomes around 6,5 times faster.

ralexstokes commented 2 months ago

linter error looks like a new issue from a nightly release -- ill go fix and then we can merge this in

ralexstokes commented 2 months ago

@mempirate if you rebase against main ill merge this in

mempirate commented 2 months ago

@ralexstokes this branch should be up to date, nothing to rebase. Maybe I misunderstood

ralexstokes commented 2 months ago

hmm yeah im a little confused why the linter is still failing, let me see what I can do -- maybe I just merge anyway as I don't think it will fail on main