Closed doubledup closed 1 year ago
so it's down to a cautiousness vs performance tradeoff.
I think we are fine to just add comments like you have done; I would consider calling them out explicitly with a SAFETY:
marker in the comments
Patch coverage: 95.74
% and project coverage change: +30.97
:tada:
Comparison is base (
2300ff8
) 44.28% compared to head (8bde6b5
) 75.26%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
For #22, I've looked through the places we've used subtraction and haven't found any cases where
checked_sub
is strictly necessary. The constraints for each case are documented in comments before the subtraction. I've also added a few constraints where necessary.~Opening as a draft since I'm not sure whether we want to use checked_sub anyway, just in case the constraints change and we miss something. There is a small performance cost to checked_sub and I'm fairly certain it's unnecessary, so it's down to a cautiousness vs performance tradeoff.~