search

ralexstokes / ssz-rs

Implementation of ethereum's `ssz`
Apache License 2.0
102 stars 40 forks source link

Replaces debug_assert_eq with size check errors #79

Closed claravanstaden closed 1 year ago

claravanstaden commented 1 year ago

From audit:

We recommend implementing mentioned checks with an error handling logic in order to perform them also in production code.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.27 :warning:

Comparison is base (b872969) 75.26% compared to head (de0fe5a) 75.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #79 +/- ## ========================================== - Coverage 75.26% 75.00% -0.27% ========================================== Files 18 18 Lines 857 860 +3 ========================================== Hits 645 645 - Misses 212 215 +3 ``` | [Impacted Files](https://app.codecov.io/gh/ralexstokes/ssz-rs/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alex+Stokes) | Coverage Δ | | |---|---|---| | [ssz-rs/src/ser.rs](https://app.codecov.io/gh/ralexstokes/ssz-rs/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alex+Stokes#diff-c3N6LXJzL3NyYy9zZXIucnM=) | `72.54% <50.00%> (-4.54%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

claravanstaden commented 1 year ago

Cool, closing in favour of https://github.com/ralexstokes/ssz-rs/pull/81. 🙃