search

ralexstokes / ssz-rs

Implementation of ethereum's `ssz`
Apache License 2.0
102 stars 40 forks source link

error on extra input when deserializing `Union[None]` for some SSZ union type #83

Closed ralexstokes closed 1 year ago

ralexstokes commented 1 year ago

discovered in the Oak Security audit

Excess bytes in the encoding of None do not trigger errors

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.02 :tada:

Comparison is base (b872969) 75.26% compared to head (39d1bb7) 75.29%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #83 +/- ## ========================================== + Coverage 75.26% 75.29% +0.02% ========================================== Files 18 18 Lines 857 862 +5 ========================================== + Hits 645 649 +4 - Misses 212 213 +1 ``` | [Impacted Files](https://app.codecov.io/gh/ralexstokes/ssz-rs/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alex+Stokes) | Coverage Δ | | |---|---|---| | [ssz-rs/src/union.rs](https://app.codecov.io/gh/ralexstokes/ssz-rs/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alex+Stokes#diff-c3N6LXJzL3NyYy91bmlvbi5ycw==) | `56.66% <66.66%> (+4.66%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.