add EncodeConfig::max_frame_rate

ralfbiedert / openh264-rs

Idiomatic Rust wrappers around OpenH264.

69 stars 35 forks source link

add EncodeConfig::max_frame_rate #15

Closed astraw closed 2 years ago

ralfbiedert commented 2 years ago

Thanks!

Just with the previous one, could you just add a short /// ... line to the pub method explaining what the setting does so people get IDE hints?

astraw commented 2 years ago

Sure. I updated the PR.

ralfbiedert commented 2 years ago

Btw, do you want a new release?

I was holding back with a new one since 1.64 would be the MSRV on master, but if there is demand I can just push another one for 1.63 right now.

astraw commented 2 years ago

Thanks! I am afraid the backtrace changes will not arrive until rust 1.65. I don't think pushing a new patch release that breaks compatibility with existing stable is a good idea. I have made PR #17 to address this. If you think this is OK to merge, then yes a new release would be great.