search

ralfbiedert / openh264-rs

Idiomatic Rust wrappers around OpenH264.
66 stars 32 forks source link

add EncoderConfig::rate_control_mode #20

Closed astraw closed 1 year ago

astraw commented 1 year ago

This adds add EncoderConfig::rate_control_mode.

I'm not entirely sure about the default value for RateControlMode. I made a runtime check of the value of params.iRCMode after raw_api.get_default_params(&mut params).ok()?; in Encoder::with_config and it was 0. This corresponds to RateControlMode::Quality, so this is the value I used in the implementation of Default for RateControlMode.

After merging this, I would be grateful if you would publish a new release. Thanks again!

ralfbiedert commented 1 year ago

0.2.16 is out

astraw commented 1 year ago

Thanks so much!