Closed soheilsalimidev closed 1 year ago
Thanks for the PR. I'd be willing to (temporarily) link a lightweight 3rd party library for faster YUV - RGB conversion, although it would be nicer to just optimize our code.
However, the crate you propose is another native lib with complex build logic that downloads 3rd party code during compilation.
While compiling the native OpenH264 C lib to this crate was a necessity, I very much want to avoid other native libs, or anything that complicates building this crate any further.
I agree this lib is complex and in most scenarios unnecessary but I think it is a good feature to have if someone is willing to pay the cost of having another c lib or at least can be added as an example
PS: I searched for a pure rust alternative to this lib or anything fast enough(I use this for streaming video) for this conversion but I had no luck finding one
anyway if you think it's not necessary then I think you should close it. Thanks for reviewing the PR
Alright, closing for now. I think it's better for people to link this crate themselves if they have a need for speed. That said, PRs for other format conversions in our lib are welcome.
use libyuv for rgb to yuv color conversion which is faster than correct implementation and also adding support for argb to yuv
test on i7-11800H