search

ralfbiedert / openh264-rs

Idiomatic Rust wrappers around OpenH264.
66 stars 32 forks source link

Reduce fix u v stride asserts #53

Closed xnorpx closed 4 weeks ago

xnorpx commented 1 month ago

I am no expert on this, but at least the encoded stream seems fine reading from a y4m file using the slice.

xnorpx commented 1 month ago

attempt to fix #52

ralfbiedert commented 1 month ago

Sorry for delay, on vacation right now, will look at this next week.

ralfbiedert commented 1 month ago

Could you add one or more unit tests which check these asserts? You can use #[should_panic] for that.

xnorpx commented 1 month ago

I will come back and a test for this once time allows.

xnorpx commented 1 month ago

Ok added some tests for asserts, been running the yuvslice with y4m crate quite heavily for last couple of weeks so seems to work well.

ralfbiedert commented 4 weeks ago

Thanks!