search

ralhei / pyRserve

A python client for Rserve (network layer to remote R server)
Other
48 stars 13 forks source link

More useful S4 class #15

Closed flying-sheep closed 7 years ago

flying-sheep commented 7 years ago

S4 classes currently expose too many externals and are hard to create from python (as you need to create and pass a lexeme)

This implements my suggestions from #14

flying-sheep commented 7 years ago

huh, setup.py says this is python 3 only, but the tests run on python 2?

either the tests have to be switched to python 3 or python 2 has to be added to the trove classifiers.

i added #16 for this

ralhei commented 7 years ago

You are right, the trove classifier is wrong, it should be 'python 2' for now, the Python3 implementation doesn't work yet. I'll take care of it asap. For now could you please adapt your code to support python2 (and 3)? I'll make suggestions in the code review.

flying-sheep commented 7 years ago

OK, all done!

but why do you say the python 3 version doesn’t work? works fine for me…

ralhei commented 7 years ago

I saw #16, and I'm about finalizing for Python3. There has just been reported an issue #17 with Python3 which I can reproduce on my side, seems to fail on py 3.5.1 and py 3.6.1, don't know why it works for you ;-) But I'm going to fix this and push the change today.