ralhei / pyRserve

A python client for Rserve (network layer to remote R server)
Other
47 stars 13 forks source link

Doesn’t build from sdist #31

Closed flying-sheep closed 1 year ago

flying-sheep commented 1 year ago

If you try to install from the source distribution hosted on PyPI, you get

* Getting build dependencies for wheel...
Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
    main()
  […]
  File "/usr/lib/python3.11/site-packages/setuptools/build_meta.py", line 338, in run_setup
    exec(code, locals())
  File "<string>", line 7, in <module>
FileNotFoundError: [Errno 2] No such file or directory: 'requirements.txt'

I suggest switching to pyproject.toml and away from setuptools to stop having to deal with its MANIFEST.in sillyness.

ralhei commented 1 year ago

Yes, indeed this was missing. I've added the requirement files to setup.py, no need to add a MANIFESTS files. The latest version is now 1.0.3 Thanks for reporting this problem.

flying-sheep commented 1 year ago

thank you!