ralish / DecodeWheaRecord

Decode hex-encoded Windows Hardware Event Architecture (WHEA) records
MIT License
13 stars 1 forks source link

Add simple test project & misc fixes #1

Closed kirhgoph closed 1 year ago

kirhgoph commented 1 year ago

This useful app crashes for me with JsonSerializationException: "A member with the name 'Signature' already exists on 'DecodeWheaRecord.NativeMethods+WHEA_ERROR_RECORD_HEADER'. Use the JsonPropertyAttribute to specify another name" So I fixed this, added a smoke test and updated the pipeline to run the test after each build

ralish commented 1 year ago

This is great, thank-you! I'll take a proper look and merge over the weekend. I have some local changes as well to push that adds support for many more additional WHEA messages. Glad you're finding it useful, I haven't spent much time on it due to time constraints, but would like to continue to improve it over the coming months.

kirhgoph commented 1 year ago

I'm glad to hear that you plan to continue the support of this tool, thank you I need to tell you this: As you can see there was the second project added, and because of this sometimes nuget restore uses only the main .csproj file and thus doesn't restore packages needed for tests, but retry helps. More info about this issue is available here in logs: https://dev.azure.com/nexiom/DecodeWheaRecord/_build/results?buildId=69&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=53352b99-bc56-513f-dcdf-57009ff4318b&l=21 I couldn't figure this out myself. Maybe you have more experience with this

ralish commented 1 year ago

Thanks @kirhgoph, I've merged this to main. I also have some major improvements on the way which add support for the majority of WHEA events which can be recorded to the Microsoft-Windows-Kernel-WHEA/Operational log.