search

ralish / DecodeWheaRecord

Decode hex-encoded Windows Hardware Event Architecture (WHEA) records
MIT License
13 stars 1 forks source link

Fix project intermediate outputs being clobbered #2

Closed kirhgoph closed 1 year ago

kirhgoph commented 1 year ago

Unfortunately previous PR https://github.com/ralish/DecodeWheaRecord/pull/1 introduced build flakiness, as you can see there: https://dev.azure.com/nexiom/DecodeWheaRecord/_build/results?buildId=75&view=results This PR fixes it.

It turned out that during the "nuget restore" command execution Nuget was trying to create 2 different project.assets.json files in the same folder. And a build was successful only if the last such file was about the project with tests. Now Nuget creates these files in different folders, so the building process is robust.

Also, the restoreNugetPackages option for VSBuild@1 Azure DevOps pipeline task is deprecated and replaced NuGetCommand@2 task, so I deleted it

ralish commented 1 year ago

Thanks @kirhgoph! I noticed this myself and have it fixed locally as part of a larger set of changes but haven't pushed it yet, so I'll just merge your quick fix and rebase on it. I'm hoping to push support for a large number of WHEA events later today.