ralismark / nix-appimage

Convert a nixos derivation into a self-contained binary
MIT License
148 stars 17 forks source link

Type error when running README example #12

Closed jbedo closed 3 months ago

jbedo commented 4 months ago

A type error was introduced in 7a27a6c68918bd2d133e1cb8797937e11d9cb98c:

❯ nix bundle --bundler github:ralismark/nix-appimage/7a27a6c nixpkgs#hello
error:
       … while calling the 'derivationStrict' builtin

         at /builtin/derivation.nix:9:12: (source not available)

       … while evaluating derivation 'hello-2.12.1-x86_64.AppImage'
         whose name attribute is located at /nix/store/d5c6h5p16jg2rna7db5y4s3y19dmwvx6-source/pkgs/stdenv/generic/make-derivation.nix:278:7

       … while evaluating attribute 'buildCommand' of derivation 'hello-2.12.1-x86_64.AppImage'

         at /nix/store/d5c6h5p16jg2rna7db5y4s3y19dmwvx6-source/pkgs/build-support/trivial-builders.nix:73:14:

           72|     stdenv.mkDerivation ({
           73|       inherit buildCommand name;
             |              ^
           74|       passAsFile = [ "buildCommand" ]

       error: cannot coerce a list to a string

The preceeding commit ecaffbe33535509cadb198f142849295f4dfeca4 does not throw this error.

kai-tub commented 3 months ago

Hey, it looks like this would be fixed by #11

Rucadi commented 3 months ago

Can confirm that this nix bundle --bundler github:tek/nix-appimage/tek/fix-exclude-args nixpkgs#hello works

ralismark commented 3 months ago

Fixed by #11.