search

rallat / EffectiveAndroid

This sample project shows how to apply MVP and Clean architecture on an Android app
1.71k stars 166 forks source link

Clean Architecture query #16

Open esoxjem opened 8 years ago

esoxjem commented 8 years ago

@rallat Uncle Bob says when you open the package structure, it should scream the intent of the application and not the tools/framework used. Right now the packages model, presenter, service, ui just tell me about the tools, that MVP is used. What's your opinion?

epeterson320 commented 8 years ago

"Package by feature, not by layer" is the advice I've heard. I haven't yet seen a Clean Architecture example repository that follows this advice, and I'll admit I was hoping to find it here.

Rainer-Lang commented 8 years ago

Take a look here... https://github.com/android10/Android-CleanArchitecture/issues/112

esoxjem commented 8 years ago

@epeterson320 I've taken a shot at it. https://github.com/esoxjem/MovieGuide

esoxjem commented 8 years ago

@Rainer-Lang Your package structure talks about the tools (data, domain, presentation) and not the intent.